set_refund_for_current_tx #2361
Conversation
| @@ -145,14 +146,15 @@ impl<S: ReadStorage> Vm<S> { | |||
| .as_u64(); | |||
|
|
|||
| let pubdata_published = self.inner.world_diff.pubdata.0 as u32; | |||
| //pubdata_published -= pubdata_before; | |||
There was a problem hiding this comment.
Please remove if this code isn't needed. BTW, how would pubdata computations work if the entire batch is executed (i.e., execution_mode == VmExecutionMode::Batch)? I'd think that pubdata_before needs to be updated somewhere in run() (in TxHasEnded hook handler?).
There was a problem hiding this comment.
I've changed it to be updated here on the spot, as for now i do not have a better theory about where it should be updated.
There was a problem hiding this comment.
I don't think it's correct (it would probably lead to the previous issue of pubdata_published for a transaction including pubdata produced by the bootloader / system contracts after executing the previous transaction), but let's fix this sequentially.
What ❔
Fixes refund-related bugs in the glue code for the new VM:
pubdata_publishedas a difference with the previous transaction